diff options
author | Aaron Marcher <me@drkhsh.at> | 2018-05-06 22:28:56 +0200 |
---|---|---|
committer | Aaron Marcher <me@drkhsh.at> | 2018-05-06 22:28:56 +0200 |
commit | ee5ec756218c852385c5ba5ef0f75b47ba59ec39 (patch) | |
tree | 2cc3cd4e654671d509dceb572c7c72d3bfde5e9d /components/run_command.c | |
parent | 66a7fb16fc903ac7ef6ce1acdbb353f1072cd0ec (diff) |
Fix coding style
- Use block for single statement ifs
- Keep lines to reasonable length (current debate as to reasonable)
- When functions return -1 for error test against 0 not -1
- Do not indent cases another level
- Do not test against NULL and 0 explicitly
- Use tabs for indentation, use spaces for alignment
Diffstat (limited to 'components/run_command.c')
-rw-r--r-- | components/run_command.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/components/run_command.c b/components/run_command.c index e356620..1aaae20 100644 --- a/components/run_command.c +++ b/components/run_command.c @@ -17,10 +17,12 @@ run_command(const char *cmd) } p = fgets(buf, sizeof(buf) - 1, fp); pclose(fp); - if (!p) + if (!p) { return NULL; - if ((p = strrchr(buf, '\n')) != NULL) + } + if ((p = strrchr(buf, '\n'))) { p[0] = '\0'; + } return buf[0] ? buf : NULL; } |