From ee5ec756218c852385c5ba5ef0f75b47ba59ec39 Mon Sep 17 00:00:00 2001 From: Aaron Marcher Date: Sun, 6 May 2018 22:28:56 +0200 Subject: Fix coding style - Use block for single statement ifs - Keep lines to reasonable length (current debate as to reasonable) - When functions return -1 for error test against 0 not -1 - Do not indent cases another level - Do not test against NULL and 0 explicitly - Use tabs for indentation, use spaces for alignment --- components/run_command.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'components/run_command.c') diff --git a/components/run_command.c b/components/run_command.c index e356620..1aaae20 100644 --- a/components/run_command.c +++ b/components/run_command.c @@ -17,10 +17,12 @@ run_command(const char *cmd) } p = fgets(buf, sizeof(buf) - 1, fp); pclose(fp); - if (!p) + if (!p) { return NULL; - if ((p = strrchr(buf, '\n')) != NULL) + } + if ((p = strrchr(buf, '\n'))) { p[0] = '\0'; + } return buf[0] ? buf : NULL; } -- cgit v1.2.3