diff options
author | Laslo Hunhold <dev@frign.de> | 2018-05-01 18:10:39 +0200 |
---|---|---|
committer | Aaron Marcher <me@drkhsh.at> | 2018-05-01 19:43:34 +0200 |
commit | 42edfea89a47cbf0623d1aaf5673a4e5ca79fb52 (patch) | |
tree | 232cb4eed053d1399dfeb396996cef87973661ab /components/OpenBSD | |
parent | d42870d6ca7fb587b38f8cf6d6821ae33a53a696 (diff) |
Revert component-split
this reverts the commits from 92ab9ef52ebcb097add97d9f78e67ad1c1d6a6ec up to
d42870d6ca7fb587b38f8cf6d6821ae33a53a696.
After heavy consideration, the component split has more disadvantages
than advantages, especially given there will be utility-functions
sharing quite a lot of code that would then need to be duplicated, as it
does not fit into the util.c due to its speciality.
One big advantage of the component-wise build is readability, and
without doubt, this was achieved here. This point will be addressed
with a different approach that will be visible in the upcoming commits.
One big disadvantage of the component build is the fact that it
introduces state to the build process which is not necessary. Before its
introduction, the only influencing factors where the system-defines
__linux__ and __OpenBSD__. With the components, we are also relying on
the output of uname(1).
Additionally, if the os.mk is not present, make gives the output
$ make
Makefile:5: os.mk: No such file or directory
make: *** No rule to make target 'os.mk'. Stop.
This could easily be fixed by providing some sort of meta-rule for this
file, however, it indicates the problem we have here, and this entire
statefulness will heavily complicate packaging of this tool and makes
the build process much more complex than it actually has to be.
Diffstat (limited to 'components/OpenBSD')
-rw-r--r-- | components/OpenBSD/battery.c | 32 | ||||
-rw-r--r-- | components/OpenBSD/cpu.c | 26 | ||||
-rw-r--r-- | components/OpenBSD/entropy.c | 0 | ||||
-rw-r--r-- | components/OpenBSD/ram.c | 77 | ||||
-rw-r--r-- | components/OpenBSD/swap.c | 0 | ||||
-rw-r--r-- | components/OpenBSD/temperature.c | 32 | ||||
-rw-r--r-- | components/OpenBSD/uptime.c | 40 | ||||
-rw-r--r-- | components/OpenBSD/wifi.c | 0 |
8 files changed, 0 insertions, 207 deletions
diff --git a/components/OpenBSD/battery.c b/components/OpenBSD/battery.c deleted file mode 100644 index daefd77..0000000 --- a/components/OpenBSD/battery.c +++ /dev/null @@ -1,32 +0,0 @@ -/* See LICENSE file for copyright and license details. */ -#include <errno.h> -#include <stdio.h> -#include <string.h> -#include <sys/ioctl.h> -#include <fcntl.h> -#include <unistd.h> -#include <machine/apmvar.h> - -#include "../../util.h" - -const char * -battery_perc(const char *null) -{ - struct apm_power_info apm_info; - int fd; - - fd = open("/dev/apm", O_RDONLY); - if (fd < 0) { - fprintf(stderr, "open '/dev/apm': %s\n", strerror(errno)); - return NULL; - } - - if (ioctl(fd, APM_IOC_GETPOWER, &apm_info) < 0) { - fprintf(stderr, "ioctl 'APM_IOC_GETPOWER': %s\n", strerror(errno)); - close(fd); - return NULL; - } - close(fd); - - return bprintf("%d", apm_info.battery_life); -} diff --git a/components/OpenBSD/cpu.c b/components/OpenBSD/cpu.c deleted file mode 100644 index 11f1812..0000000 --- a/components/OpenBSD/cpu.c +++ /dev/null @@ -1,26 +0,0 @@ -/* See LICENSE file for copyright and license details. */ -#include <errno.h> -#include <stdio.h> -#include <string.h> -#include <sys/sysctl.h> - -#include "../../util.h" - -const char * -cpu_freq(void) -{ - int freq, mib[2]; - size_t size; - - mib[0] = CTL_HW; - mib[1] = HW_CPUSPEED; - - size = sizeof(freq); - - if (sysctl(mib, 2, &freq, &size, NULL, 0) == -1) { - fprintf(stderr, "sysctl 'HW_CPUSPEED': %s\n", strerror(errno)); - return NULL; - } - - return bprintf("%d", freq); -} diff --git a/components/OpenBSD/entropy.c b/components/OpenBSD/entropy.c deleted file mode 100644 index e69de29..0000000 --- a/components/OpenBSD/entropy.c +++ /dev/null diff --git a/components/OpenBSD/ram.c b/components/OpenBSD/ram.c deleted file mode 100644 index f7c81d1..0000000 --- a/components/OpenBSD/ram.c +++ /dev/null @@ -1,77 +0,0 @@ -/* See LICENSE file for copyright and license details. */ -#include <stdio.h> -#include <sys/types.h> -#include <sys/sysctl.h> -#include <stdlib.h> -#include <unistd.h> - -#include "../../util.h" - -inline int -load_uvmexp(struct uvmexp *uvmexp) -{ - int uvmexp_mib[] = {CTL_VM, VM_UVMEXP}; - size_t size; - - size = sizeof(*uvmexp); - - return sysctl(uvmexp_mib, 2, uvmexp, &size, NULL, 0) >= 0 ? 1 : 0; -} - -const char * -ram_free(void) -{ - struct uvmexp uvmexp; - float free; - int free_pages; - - if (load_uvmexp(&uvmexp)) { - free_pages = uvmexp.npages - uvmexp.active; - free = (double) (free_pages * uvmexp.pagesize) / 1024 / 1024 / 1024; - return bprintf("%f", free); - } - - return NULL; -} - -const char * -ram_perc(void) -{ - struct uvmexp uvmexp; - int percent; - - if (load_uvmexp(&uvmexp)) { - percent = uvmexp.active * 100 / uvmexp.npages; - return bprintf("%d", percent); - } - - return NULL; -} - -const char * -ram_total(void) -{ - struct uvmexp uvmexp; - float total; - - if (load_uvmexp(&uvmexp)) { - total = (double) (uvmexp.npages * uvmexp.pagesize) / 1024 / 1024 / 1024; - return bprintf("%f", total); - } - - return NULL; -} - -const char * -ram_used(void) -{ - struct uvmexp uvmexp; - float used; - - if (load_uvmexp(&uvmexp)) { - used = (double) (uvmexp.active * uvmexp.pagesize) / 1024 / 1024 / 1024; - return bprintf("%f", used); - } - - return NULL; -} diff --git a/components/OpenBSD/swap.c b/components/OpenBSD/swap.c deleted file mode 100644 index e69de29..0000000 --- a/components/OpenBSD/swap.c +++ /dev/null diff --git a/components/OpenBSD/temperature.c b/components/OpenBSD/temperature.c deleted file mode 100644 index 8098868..0000000 --- a/components/OpenBSD/temperature.c +++ /dev/null @@ -1,32 +0,0 @@ -/* See LICENSE file for copyright and license details. */ -#include <errno.h> -#include <stdio.h> -#include <string.h> -#include <sys/sysctl.h> -#include <sys/time.h> -#include <sys/sensors.h> - -#include "../../util.h" - -const char * -temp(const char *null) -{ - int mib[5]; - size_t size; - struct sensor temp; - - mib[0] = CTL_HW; - mib[1] = HW_SENSORS; - mib[2] = 0; /* cpu0 */ - mib[3] = SENSOR_TEMP; - mib[4] = 0; /* temp0 */ - - size = sizeof(temp); - - if (sysctl(mib, 5, &temp, &size, NULL, 0) == -1) { - fprintf(stderr, "sysctl 'SENSOR_TEMP': %s\n", strerror(errno)); - return NULL; - } - - return bprintf("%d", (temp.value - 273150000) / 1000000); /* kelvin to celsius */ -} diff --git a/components/OpenBSD/uptime.c b/components/OpenBSD/uptime.c deleted file mode 100644 index 637e2e0..0000000 --- a/components/OpenBSD/uptime.c +++ /dev/null @@ -1,40 +0,0 @@ -/* See LICENSE file for copyright and license details. */ -#include <errno.h> -#include <stdio.h> -#include <string.h> -#include <sys/sysctl.h> -#include <sys/time.h> - -#include "../../util.h" - -const char * -uptime(void) -{ - int h; - int m; - int uptime = 0; - - int mib[2]; - size_t size; - time_t now; - struct timeval boottime; - - time(&now); - - mib[0] = CTL_KERN; - mib[1] = KERN_BOOTTIME; - - size = sizeof(boottime); - - if (sysctl(mib, 2, &boottime, &size, NULL, 0) != -1) - uptime = now - boottime.tv_sec; - else { - fprintf(stderr, "sysctl 'KERN_BOOTTIME': %s\n", strerror(errno)); - return NULL; - } - - h = uptime / 3600; - m = (uptime - h * 3600) / 60; - - return bprintf("%dh %dm", h, m); -} diff --git a/components/OpenBSD/wifi.c b/components/OpenBSD/wifi.c deleted file mode 100644 index e69de29..0000000 --- a/components/OpenBSD/wifi.c +++ /dev/null |