From 5a218e990ca05e6bb087f4fecaaa4807fbe69528 Mon Sep 17 00:00:00 2001 From: raiz Date: Sun, 18 Dec 2016 10:35:36 +0300 Subject: remove unused strlcpy() and reduce the size of output buffer --- slstatus.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'slstatus.c') diff --git a/slstatus.c b/slstatus.c index 2b63be4..2d5d173 100644 --- a/slstatus.c +++ b/slstatus.c @@ -759,7 +759,7 @@ int main(int argc, char *argv[]) { unsigned short int i; - char status_string[4096]; + char status_string[2048]; char *res, *element; struct arg argument; struct sigaction act; @@ -811,7 +811,8 @@ main(int argc, char *argv[]) element = smprintf(UNKNOWN_STR); warnx("Failed to format output"); } - strlcat(status_string, element, sizeof(status_string)); + if (strlcat(status_string, element, sizeof(status_string)) >= sizeof(status_string)) + warnx("Output too long"); free(res); free(element); } -- cgit v1.2.3