From 42edfea89a47cbf0623d1aaf5673a4e5ca79fb52 Mon Sep 17 00:00:00 2001 From: Laslo Hunhold Date: Tue, 1 May 2018 18:10:39 +0200 Subject: Revert component-split this reverts the commits from 92ab9ef52ebcb097add97d9f78e67ad1c1d6a6ec up to d42870d6ca7fb587b38f8cf6d6821ae33a53a696. After heavy consideration, the component split has more disadvantages than advantages, especially given there will be utility-functions sharing quite a lot of code that would then need to be duplicated, as it does not fit into the util.c due to its speciality. One big advantage of the component-wise build is readability, and without doubt, this was achieved here. This point will be addressed with a different approach that will be visible in the upcoming commits. One big disadvantage of the component build is the fact that it introduces state to the build process which is not necessary. Before its introduction, the only influencing factors where the system-defines __linux__ and __OpenBSD__. With the components, we are also relying on the output of uname(1). Additionally, if the os.mk is not present, make gives the output $ make Makefile:5: os.mk: No such file or directory make: *** No rule to make target 'os.mk'. Stop. This could easily be fixed by providing some sort of meta-rule for this file, however, it indicates the problem we have here, and this entire statefulness will heavily complicate packaging of this tool and makes the build process much more complex than it actually has to be. --- components/temperature.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 components/temperature.c (limited to 'components/temperature.c') diff --git a/components/temperature.c b/components/temperature.c new file mode 100644 index 0000000..e2c6a77 --- /dev/null +++ b/components/temperature.c @@ -0,0 +1,45 @@ +/* See LICENSE file for copyright and license details. */ +#include +#include +#include +#if defined(__OpenBSD__) +#include +#include +#include +#endif + +#include "../util.h" + +#if defined(__linux__) +const char * +temp(const char *file) +{ + int temp; + + return (pscanf(file, "%d", &temp) == 1) ? + bprintf("%d", temp / 1000) : NULL; +} +#elif defined(__OpenBSD__) +const char * +temp(const char *null) +{ + int mib[5]; + size_t size; + struct sensor temp; + + mib[0] = CTL_HW; + mib[1] = HW_SENSORS; + mib[2] = 0; /* cpu0 */ + mib[3] = SENSOR_TEMP; + mib[4] = 0; /* temp0 */ + + size = sizeof(temp); + + if (sysctl(mib, 5, &temp, &size, NULL, 0) == -1) { + fprintf(stderr, "sysctl 'SENSOR_TEMP': %s\n", strerror(errno)); + return NULL; + } + + return bprintf("%d", (temp.value - 273150000) / 1000000); /* kelvin to celsius */ +} +#endif -- cgit v1.2.3