From ee5ec756218c852385c5ba5ef0f75b47ba59ec39 Mon Sep 17 00:00:00 2001 From: Aaron Marcher Date: Sun, 6 May 2018 22:28:56 +0200 Subject: Fix coding style - Use block for single statement ifs - Keep lines to reasonable length (current debate as to reasonable) - When functions return -1 for error test against 0 not -1 - Do not indent cases another level - Do not test against NULL and 0 explicitly - Use tabs for indentation, use spaces for alignment --- components/num_files.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'components/num_files.c') diff --git a/components/num_files.c b/components/num_files.c index acf9dfa..1a918ac 100644 --- a/components/num_files.c +++ b/components/num_files.c @@ -13,14 +13,15 @@ num_files(const char *dir) DIR *fd; int num = 0; - if ((fd = opendir(dir)) == NULL) { + if (!(fd = opendir(dir))) { fprintf(stderr, "opendir '%s': %s\n", dir, strerror(errno)); return NULL; } - while ((dp = readdir(fd)) != NULL) { - if (!strcmp(dp->d_name, ".") || !strcmp(dp->d_name, "..")) + while ((dp = readdir(fd))) { + if (!strcmp(dp->d_name, ".") || !strcmp(dp->d_name, "..")) { continue; /* skip self and parent */ + } num++; } -- cgit v1.2.3